Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 159021: Flip screen coordinates when converting NSEvent to WebMouseEvent. Enable proc... (Closed)

Created:
11 years, 5 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Flip screen coordinates when converting NSEvent to WebMouseEvent. Enable processing of events during drag. BUG=16909, 113616 TEST=dragging thumbnails works on NTP, dragging emails in gmail. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20989

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/api/src/mac/WebInputEventFactory.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pink (ping after 24hrs)
11 years, 5 months ago (2009-07-17 19:23:20 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/159021/diff/1/3 File chrome/browser/tab_contents/tab_contents_view_mac.mm (right): http://codereview.chromium.org/159021/diff/1/3#newcode190 Line 190: MessageLoop::current()->SetNestableTasksAllowed(true); Don't like this. When does this get ...
11 years, 5 months ago (2009-07-17 19:35:13 UTC) #2
pink (ping after 24hrs)
new patch pushed. http://codereview.chromium.org/159021/diff/1/3 File chrome/browser/tab_contents/tab_contents_view_mac.mm (right): http://codereview.chromium.org/159021/diff/1/3#newcode190 Line 190: MessageLoop::current()->SetNestableTasksAllowed(true); On 2009/07/17 19:35:13, Avi ...
11 years, 5 months ago (2009-07-17 19:44:07 UTC) #3
Avi (use Gerrit)
LG http://codereview.chromium.org/159021/diff/8/1004 File chrome/browser/tab_contents/tab_contents_view_mac.mm (right): http://codereview.chromium.org/159021/diff/8/1004#newcode441 Line 441: MessageLoop::current()->SetNestableTasksAllowed(false); A comment perhaps on this call ...
11 years, 5 months ago (2009-07-17 19:47:57 UTC) #4
Avi (use Gerrit)
11 years, 5 months ago (2009-07-17 19:53:41 UTC) #5
[Approved]

Powered by Google App Engine
This is Rietveld 408576698