Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 159019: Begin work on extension shelf for Linux. (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Begin work on extension shelf for Linux. For now it displays only a placeholder text, but knows when to display (it's connected to the ExtensionShelfModel). TEST=none http://crbug.com/16759 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -1 line) Patch
M chrome/browser/extensions/extension_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 7 chunks +22 lines, -1 line 0 comments Download
A chrome/browser/gtk/extension_shelf_gtk.h View 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/gtk/extension_shelf_gtk.cc View 1 chunk +131 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Please review: erg: Linux UI part. erikkay: extensions part. If you think it's too much ...
11 years, 5 months ago (2009-07-17 18:58:35 UTC) #1
Elliot Glaysher
GTK parts LGTM.
11 years, 5 months ago (2009-07-17 19:12:32 UTC) #2
Erik does not do reviews
11 years, 5 months ago (2009-07-17 21:10:07 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698