Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1589027: Prepare tpm-emulator for emerge (do not try to compile kernel module). (Closed)

Created:
10 years, 8 months ago by Luigi Semenzato
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fix cmakefile in tpm-emulator for emerge. The kernel module is copied to the kernel tree and compiled separately.

Patch Set 1 #

Patch Set 2 : CMakeLists.txt changes for separate kernel module compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M CMakeLists.txt View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Luigi Semenzato
Hi Mandeep, thanks for looking at this. I need these changes before I can add ...
10 years, 8 months ago (2010-04-09 23:45:27 UTC) #1
Mandeep Singh Baines
This is really two independent changes. One of which can be upstreamed. Could you submit ...
10 years, 8 months ago (2010-04-12 17:13:44 UTC) #2
Luigi Semenzato
On 2010/04/12 17:13:44, msb wrote: > This is really two independent changes. One of which ...
10 years, 8 months ago (2010-04-12 21:27:28 UTC) #3
Mandeep Singh Baines
10 years, 8 months ago (2010-04-12 21:39:04 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698