Status area improvements:...

Status area improvements:
- text is now 70% alpha
- font is 1 size larger
- 6 pixels between status icons
- icon and text are lined up better
- when clock changes text, bounds are reset properly

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44128

[Charlie Lee, 2010-04-06 22:55:27]

Scott,

There are 2 things I want your opinion on:

1) Is my change to canvas_linux an ok change? Basically I want the support to be
able to draw text with alpha. Currently, it doesn't use the alpha field from the
color variable. This change will make the linux implementation inconsistent with
win/mac. If we want to make the same change for win/mac, it looks like a simple
change for Mac but not sure about Win. Or I can create a separate method like
DrawStringWithAlphaInt.

2) I added code in ClockMenuButton that would readjust the size/bounds of the
parent status area when the text changes size. For example, if the time when
from 9:59 to 10:00, the size increases by about 10 pixels. So I would need to
move the bounds of the status area view left by 10 pixels and then increase the
width by 10 pixels. What I have works, but seems very hackish. Can you think of
a better way to implement this?

Thanks,
Charlie

[sky, 2010-04-07 17:11:02]

I think your change to canvas is fine, but you need to make sure all callers
supply an alpha of 255.

http://codereview.chromium.org/1589021/diff/1/7
File chrome/browser/chromeos/status/clock_menu_button.cc (right):

http://codereview.chromium.org/1589021/diff/1/7#newcode114
chrome/browser/chromeos/status/clock_menu_button.cc:114: SizeToPreferredSize();
Insted of this, do:

if (new_width != cur_width)
  PreferredSizeChanged();

And then change the parents to override ChildPreferredSizeChanged and invoke
Layout from it.

[Charlie Lee, 2010-04-08 21:51:57]

Scott, thanks for the suggestion. I made the changes to call
PreferredSizeChanged and have the parent monitor it and call Layout as
appropriate. This is done in both the BrowserView and BackgroundView for login
manager.

I also went ahead and added an implementation for Mac to do the alpha text
drawing b/c it was simple enough. But I have no easy way to test it. Should I
just find someone on the Mac team and have them help me test it?

There was one call DrawStringInt that now uses draw text with alpha properly but
only for non-windows platform. Can you take a close look at that in
status_bubble_views

Thanks,
Charlie

http://codereview.chromium.org/1589021/diff/1/7
File chrome/browser/chromeos/status/clock_menu_button.cc (right):

http://codereview.chromium.org/1589021/diff/1/7#newcode114
chrome/browser/chromeos/status/clock_menu_button.cc:114: SizeToPreferredSize();
On 2010/04/07 17:11:02, sky wrote:
> Insted of this, do:
> 
> if (new_width != cur_width)
>   PreferredSizeChanged();
> 
> And then change the parents to override ChildPreferredSizeChanged and invoke
> Layout from it.

Done.

[sky, 2010-04-08 22:39:20]

Ya, be sure and get someone on the mac side to test it for you.

LGTM otherwise.

http://codereview.chromium.org/1589021/diff/24001/25004
File chrome/browser/chromeos/frame/browser_view.cc (right):

http://codereview.chromium.org/1589021/diff/24001/25004#newcode437
chrome/browser/chromeos/frame/browser_view.cc:437: Layout();
Do a SchedulePaint after this too.