Issue 1589015: GTK plumbing for dragend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1589015: GTK plumbing for dragend. (Closed)

Created:
10 years, 8 months ago by dcheng

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews

Visibility:
Public.

Description

GTK plumbing for dragend. This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43679

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -34 lines)			Patch
M	app/gtk_dnd_util.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	app/gtk_dnd_util.cc	View	2 chunks	+22 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/tab_contents_drag_source.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/tab_contents_drag_source.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drag_dest_gtk.cc	View	3 chunks	+5 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

10 years, 8 months ago (2010-04-05 23:48:27 UTC) #2

LGTM
Can you update the change description so TEST= includes a description of a
manual test?  It's not obvious from the description what this patch is fixing.

Expand Messages | Collapse Messages