Added glReadPixels test.

Added glReadPixels test.

[Alexey Marinichev, 2010-03-30 02:12:33]

Should probably test IMPLEMENTATION_COLOR_READ_* as well?

[piman, 2010-03-30 02:23:46]

http://codereview.chromium.org/1588001/diff/1/2
File client/deps/glbench/src/main.cc (right):

http://codereview.chromium.org/1588001/diff/1/2#newcode793
client/deps/glbench/src/main.cc:793: // Default GL_PACK_ALIGNMENT is 4, round up
width to multiple of 4.
what's relevant here is GL_UNPACK_ALIGNMENT.
It's 4 indeed, but it's bytes not pixels, so rounding should work in bytes.
Since you're doing RGBA anyway, you have no rounding to do...

[Alexey Marinichev, 2010-03-30 02:35:55]

http://codereview.chromium.org/1588001/diff/1/2
File client/deps/glbench/src/main.cc (right):

http://codereview.chromium.org/1588001/diff/1/2#newcode793
client/deps/glbench/src/main.cc:793: // Default GL_PACK_ALIGNMENT is 4, round up
width to multiple of 4.
Man page of glPixelStore says it is GL_PACK_ALIGNMENT that is significant for
glReadPixels.

On 2010/03/30 02:23:46, piman wrote:
> what's relevant here is GL_UNPACK_ALIGNMENT.
> It's 4 indeed, but it's bytes not pixels, so rounding should work in bytes.
> Since you're doing RGBA anyway, you have no rounding to do...

[piman, 2010-03-30 02:40:53]

http://codereview.chromium.org/1588001/diff/1/2
File client/deps/glbench/src/main.cc (right):

http://codereview.chromium.org/1588001/diff/1/2#newcode793
client/deps/glbench/src/main.cc:793: // Default GL_PACK_ALIGNMENT is 4, round up
width to multiple of 4.
On 2010/03/30 02:35:56, Alexey Marinichev wrote:
> Man page of glPixelStore says it is GL_PACK_ALIGNMENT that is significant for
> glReadPixels.

Brainfart, sorry, you're correct.

[piman, 2010-03-30 19:57:42]

LGTM