Issue 1585022: Make sure to strip the brackets around IPv6 literals when resolving the hostn...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1585022: Make sure to strip the brackets around IPv6 literals when resolving the hostn... (Closed)

Created:
10 years, 8 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make sure to strip the brackets around IPv6 literals when resolving the hostname for FTP. BUG=39830 (comment #9) TEST=FtpNetworkTransactionTest.StripBracketsFromIPv6Literals Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43888

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : Address wtc's comments #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	net/ftp/ftp_network_transaction.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	net/ftp/ftp_network_transaction_unittest.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eroman

Note that this doesn't fix any end user problem (since we disable IPv6 in FTP ...

10 years, 8 months ago (2010-04-07 20:42:44 UTC) #2

wtc

LGTM. http://codereview.chromium.org/1585022/diff/4001/5002 File net/ftp/ftp_network_transaction_unittest.cc (right): http://codereview.chromium.org/1585022/diff/4001/5002#newcode683 net/ftp/ftp_network_transaction_unittest.cc:683: host_resolver_->rules()->AddSimulatedFailure("[::3]"); Nit: please use a realistic IPv6 address ...

10 years, 8 months ago (2010-04-07 21:27:49 UTC) #3

Done.

Thanks for the review!

Expand Messages | Collapse Messages