Add menu and menu item events to the accessibility extension api, and...

Add menu and menu item events to the accessibility extension api, and
generate menu item notifications for gtk menus.

The code to generate menu open and close events is a little more complicated
and will come in a future patch.

BUG=none
TEST=navigated menus with keyboard, watched notifications fire


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43707

[dmazzoni, 2010-04-01 21:09:48]

Evan,

No hurry, when you have a chance, thanks...

- Dominic

[Evan Stade, 2010-04-02 01:30:27]

mostly nits

http://codereview.chromium.org/1585011/diff/1/13
File chrome/browser/gtk/accessibility_event_router_gtk.cc (right):

http://codereview.chromium.org/1585011/diff/1/13#newcode27
chrome/browser/gtk/accessibility_event_router_gtk.cc:27:
reinterpret_cast<AccessibilityEventRouterGtk *>(user_data)->
is the space before the * needed?

http://codereview.chromium.org/1585011/diff/1/13#newcode30
chrome/browser/gtk/accessibility_event_router_gtk.cc:30: return true;
nit: s/true/TRUE

http://codereview.chromium.org/1585011/diff/1/13#newcode296
chrome/browser/gtk/accessibility_event_router_gtk.cc:296: if (!listening_) {
no curlies

http://codereview.chromium.org/1585011/diff/1/13#newcode299
chrome/browser/gtk/accessibility_event_router_gtk.cc:299: Profile *profile =
NULL;
nit: * on left

http://codereview.chromium.org/1585011/diff/1/13#newcode314
chrome/browser/gtk/accessibility_event_router_gtk.cc:314: if (!is_accessible) {
no curlies

http://codereview.chromium.org/1585011/diff/1/13#newcode553
chrome/browser/gtk/accessibility_event_router_gtk.cc:553: // of type GtkLabel.
can you use gtk_menu_item_get_label() for GTK 2.16+?

http://codereview.chromium.org/1585011/diff/1/13#newcode556
chrome/browser/gtk/accessibility_event_router_gtk.cc:556: GList *children =
gtk_container_get_children(GTK_CONTAINER(menu_item));
nit: * on left.

http://codereview.chromium.org/1585011/diff/1/8
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/1585011/diff/1/8#newcode666
chrome/browser/views/frame/browser_view.cc:666: if
(!accessible_widget_helper_.get())
curlies

[dmazzoni, 2010-04-02 14:14:31]

Thanks.

http://codereview.chromium.org/1585011/diff/1/13
File chrome/browser/gtk/accessibility_event_router_gtk.cc (right):

http://codereview.chromium.org/1585011/diff/1/13#newcode27
chrome/browser/gtk/accessibility_event_router_gtk.cc:27:
reinterpret_cast<AccessibilityEventRouterGtk *>(user_data)->
On 2010/04/02 01:30:27, Evan Stade wrote:
> is the space before the * needed?

Done.

http://codereview.chromium.org/1585011/diff/1/13#newcode30
chrome/browser/gtk/accessibility_event_router_gtk.cc:30: return true;
On 2010/04/02 01:30:27, Evan Stade wrote:
> nit: s/true/TRUE

Done.

http://codereview.chromium.org/1585011/diff/1/13#newcode296
chrome/browser/gtk/accessibility_event_router_gtk.cc:296: if (!listening_) {
On 2010/04/02 01:30:27, Evan Stade wrote:
> no curlies

Done.

http://codereview.chromium.org/1585011/diff/1/13#newcode299
chrome/browser/gtk/accessibility_event_router_gtk.cc:299: Profile *profile =
NULL;
On 2010/04/02 01:30:27, Evan Stade wrote:
> nit: * on left

Done.

http://codereview.chromium.org/1585011/diff/1/13#newcode314
chrome/browser/gtk/accessibility_event_router_gtk.cc:314: if (!is_accessible) {
On 2010/04/02 01:30:27, Evan Stade wrote:
> no curlies

Done.

http://codereview.chromium.org/1585011/diff/1/13#newcode553
chrome/browser/gtk/accessibility_event_router_gtk.cc:553: // of type GtkLabel.
On 2010/04/02 01:30:27, Evan Stade wrote:
> can you use gtk_menu_item_get_label() for GTK 2.16+?

Yes...our Google Ubuntu boxes seem to only have 2.12 installed, unfortunately. I
added a TODO.

http://codereview.chromium.org/1585011/diff/1/13#newcode556
chrome/browser/gtk/accessibility_event_router_gtk.cc:556: GList *children =
gtk_container_get_children(GTK_CONTAINER(menu_item));
On 2010/04/02 01:30:27, Evan Stade wrote:
> nit: * on left.

Done.

http://codereview.chromium.org/1585011/diff/1/8
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/1585011/diff/1/8#newcode666
chrome/browser/views/frame/browser_view.cc:666: if
(!accessible_widget_helper_.get())
On 2010/04/02 01:30:27, Evan Stade wrote:
> curlies

Done.

[Evan Stade, 2010-04-02 18:39:42]

http://codereview.chromium.org/1585011/diff/17001/13013
File chrome/browser/gtk/accessibility_event_router_gtk.cc (right):

http://codereview.chromium.org/1585011/diff/17001/13013#newcode553
chrome/browser/gtk/accessibility_event_router_gtk.cc:553: // TODO(dmazzoni):
Replace with gtk_menu_item_get_label if/when we ever
I meant,

#if GTK_CHECK_VERSION(2, 16, 0)
  name = gtk_menu_item_get_label(item);
#else
*your code*
#endif

[dmazzoni, 2010-04-05 15:49:56]

http://codereview.chromium.org/1585011/diff/17001/13013
File chrome/browser/gtk/accessibility_event_router_gtk.cc (right):

http://codereview.chromium.org/1585011/diff/17001/13013#newcode553
chrome/browser/gtk/accessibility_event_router_gtk.cc:553: // TODO(dmazzoni):
Replace with gtk_menu_item_get_label if/when we ever
On 2010/04/02 18:39:42, Evan Stade wrote:
> I meant,
> 
> #if GTK_CHECK_VERSION(2, 16, 0)
>   name = gtk_menu_item_get_label(item);
> #else
> *your code*
> #endif

Done.