Issue 1584008: Let LiveEdit accept a full new script source (rather than diff)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1584008: Let LiveEdit accept a full new script source (rather than diff) (Closed)

Created:
10 years, 8 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Visibility:
Public.

Description

Let LiveEdit accept a full new script source (rather than diff) Committed: http://code.google.com/p/v8/source/detail?r=4338

Patch Set 3 : follow codereview #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -10 lines)			Patch
M	src/debug-debugger.js	View	1 2	2 chunks	+25 lines, -10 lines	0 comments	Download
M	src/liveedit-debugger.js	View	1	1 chunk	+83 lines, -0 lines	0 comments	Download
A	test/mjsunit/debug-liveedit-newsource.js	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

LGTM http://codereview.chromium.org/1584008/diff/2001/3001 File src/debug-debugger.js (right): http://codereview.chromium.org/1584008/diff/2001/3001#newcode2008 src/debug-debugger.js:2008: invocation(); nit: alignment http://codereview.chromium.org/1584008/diff/2001/3002 File src/liveedit-debugger.js (right): http://codereview.chromium.org/1584008/diff/2001/3002#newcode446 ...

10 years, 8 months ago (2010-04-02 09:05:55 UTC) #2

Peter Rybin

10 years, 8 months ago (2010-04-02 10:14:58 UTC) #3

http://codereview.chromium.org/1584008/diff/2001/3001
File src/debug-debugger.js (right):

http://codereview.chromium.org/1584008/diff/2001/3001#newcode2008
src/debug-debugger.js:2008: invocation();
On 2010/04/02 09:05:55, Michail Naganov wrote:
> nit: alignment

Done.

http://codereview.chromium.org/1584008/diff/2001/3002
File src/liveedit-debugger.js (right):

http://codereview.chromium.org/1584008/diff/2001/3002#newcode446
src/liveedit-debugger.js:446: new_source.substring(diff.change_pos,
diff.change_pos + diff.new_len),
On 2010/04/02 09:05:55, Michail Naganov wrote:
> nit: you could use 'substr' method, which accepts length as its second
argument.

I thought this is not strictly standard.

Expand Messages | Collapse Messages

Issue 1584008: Let LiveEdit accept a full new script source (rather than diff) (Closed)

Description

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : follow codereview #

Messages