[Mac] Magnifying glass in keyword-search bubble.

[Mac] Magnifying glass in keyword-search bubble.

Abstract the image-in-attributed-string code into a helper function so
everyone makes the same mistakes.  The keyword-search string's
baseline became wrong at some point, adjust it to match the rest of
the field.

BUG=37865
TEST=Type "google.com" until "press tab to search" appears, hit TAB.  "Search Google:" bubble should have a magnifying glass on the LHS.
TEST=Add a bunch of text to search.  Resizing smaller should first remove the image, then change to shorter text ("Search Go..." or somesuch).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43540

[rohitrao (ping after 24h), 2010-04-02 21:40:25]

LGTM

http://codereview.chromium.org/1581011/diff/1/3
File chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm (right):

http://codereview.chromium.org/1581011/diff/1/3#newcode451
chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm:451:
EXPECT_TRUE([[[cell keywordString] string] hasSuffix:kFullString]);
Is there a reasonable way to test for the presence of the image?  Should we have
tests for fullwidth+image vs fullwidth+noimage?

[Scott Hess - ex-Googler, 2010-04-02 22:41:02]

Thanks!

http://codereview.chromium.org/1581011/diff/1/3
File chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm (right):

http://codereview.chromium.org/1581011/diff/1/3#newcode451
chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm:451:
EXPECT_TRUE([[[cell keywordString] string] hasSuffix:kFullString]);
On 2010/04/02 21:40:25, rohitrao wrote:
> Is there a reasonable way to test for the presence of the image?  Should we
have
> tests for fullwidth+image vs fullwidth+noimage?

Modified the test to test that there is an attachment in this case, then to snag
the laid-out width from this case, subtract a little, then check that that width
doesn't allow an image.  Seems reasonable to me.