Issue 1581008: Audio cut off ~500ms too early

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1581008: Audio cut off ~500ms too early (Closed)

Created:
10 years, 8 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews

Visibility:
Public.

Description

Audio cut off ~500ms too early BUG=23055 TEST=layout tests and audio won't cut off too early with this file: http://commons.wikimedia.org/wiki/File:Montreal2.ogg This patch fix the problem by adding an extra condition to determine the end of playback by using the information of buffered audio data in the browser process. If both the renderer process and browser process don't have any more audio data then end of playback is resulted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43546

Patch Set 1 #

Patch Set 2 : remove unrelated patch #

Patch Set 3 : missing patch #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/renderer/media/audio_renderer_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	media/filters/audio_renderer_base.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages