Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: src/platform/vboot_reference/tests/test_common.h

Issue 1578035: Change VerifyFirmware() to take separate pointers to firmware verification header and firmware data. (Closed)
Patch Set: review fixes Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/vboot_reference/tests/test_common.h
diff --git a/src/platform/vboot_reference/tests/test_common.h b/src/platform/vboot_reference/tests/test_common.h
index 6fed1b489f50abb2c72bd640a8911330b1e9b9a6..d73dc0eaff4fb5148f82d896bec26ade794fc893 100644
--- a/src/platform/vboot_reference/tests/test_common.h
+++ b/src/platform/vboot_reference/tests/test_common.h
@@ -26,13 +26,13 @@ FirmwareImage* GenerateTestFirmwareImage(int algorithm,
const char* root_key_file,
const char* firmware_key_file,
uint8_t firmware_data_fill_char);
-uint8_t* GenerateTestFirmwareBlob(int algorithm,
- const uint8_t* firmware_sign_key,
- int firmware_key_version,
- int firmware_version,
- uint64_t firmware_len,
- const char* root_key_file,
- const char* firmware_key_file);
+uint8_t* GenerateTestVerificationBlob(int algorithm,
+ const uint8_t* firmware_sign_key,
+ int firmware_key_version,
+ int firmware_version,
+ uint64_t firmware_len,
+ const char* root_key_file,
+ const char* firmware_key_file);
/* Test kernel image generation functions. */
KernelImage* GenerateTestKernelImage(int firmware_sign_algorithm,
@@ -44,7 +44,6 @@ KernelImage* GenerateTestKernelImage(int firmware_sign_algorithm,
const char* firmware_key_file,
const char* kernel_key_file,
uint8_t kernel_data_fill_char);
-;
uint8_t* GenerateTestKernelBlob(int firmware_sign_algorithm,
int kernel_sign_algorithm,
const uint8_t* kernel_sign_key,
@@ -54,12 +53,12 @@ uint8_t* GenerateTestKernelBlob(int firmware_sign_algorithm,
const char* firmware_key_file,
const char* kernel_key_file);
-/* Generates a test firmware image for rollback tests with a given
- * [firmware_key_version] and [firmware_version]. If [is_corrupt] is 1,
- * then the image has invalid signatures and will fail verification. */
-uint8_t* GenerateRollbackTestFirmwareBlob(int firmware_key_version,
- int firmware_version,
- int is_corrupt);
+/* Generates a test verification block for rollback tests with a given
+ * [firmware_key_version] and [firmware_version]. The firmware length is
+ * assumed to be 1 bytes, and containing { 'F' }.
+ */
+uint8_t* GenerateRollbackTestVerificationBlob(int firmware_key_version,
+ int firmware_version);
/* Generates a test kernel iamge for rollback tests with a given
* [kernel_key_version} and [kernel_version]. If [is_corrupt] is 1,
« no previous file with comments | « src/platform/vboot_reference/tests/firmware_verify_benchmark.c ('k') | src/platform/vboot_reference/tests/test_common.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698