Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: src/platform/vboot_reference/tests/firmware_splicing_tests.c

Issue 1578035: Change VerifyFirmware() to take separate pointers to firmware verification header and firmware data. (Closed)
Patch Set: review fixes Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/vboot_reference/tests/firmware_splicing_tests.c
diff --git a/src/platform/vboot_reference/tests/firmware_splicing_tests.c b/src/platform/vboot_reference/tests/firmware_splicing_tests.c
index c3259b7660fc3a619ba8f0a6fae34869364f408a..97d16dfcfd87b4841fc3c516ab740dc8924b910a 100644
--- a/src/platform/vboot_reference/tests/firmware_splicing_tests.c
+++ b/src/platform/vboot_reference/tests/firmware_splicing_tests.c
@@ -67,7 +67,7 @@ void VerifyFirmwareSplicingTest()
VERIFY_FIRMWARE_SIGNATURE_FAILED,
"FirmwareImage firmware_data Splicing");
firmware_blob = GetFirmwareBlob(image2, &len);
- TEST_EQ(VerifyFirmware(root_key_blob, firmware_blob),
+ TEST_EQ(VerifyFirmware(root_key_blob, firmware_blob, image2->firmware_data),
VERIFY_FIRMWARE_SIGNATURE_FAILED,
"Firmware Blob firmware_data Splicing");
}

Powered by Google App Engine
This is Rietveld 408576698