src/platform/vboot_reference/tests/big_firmware_tests.c - Issue 1578035: Change VerifyFirmware() to take separate pointers to firmware verification header and firmware data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform/vboot_reference/tests/big_firmware_tests.c

Issue 1578035: Change VerifyFirmware() to take separate pointers to firmware verification header and firmware data. (Closed)

Patch Set: review fixes Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/platform/vboot_reference/tests/big_firmware_tests.c

diff --git a/src/platform/vboot_reference/tests/big_firmware_tests.c b/src/platform/vboot_reference/tests/big_firmware_tests.c

index eb4511495fbf865b35f479a560ad6977c005cc18..1f83cd2ab4159aa4e40fbfcd7597bbff330d12da 100644

--- a/src/platform/vboot_reference/tests/big_firmware_tests.c

+++ b/src/platform/vboot_reference/tests/big_firmware_tests.c

@@ -52,7 +52,7 @@ int BigFirmwareTest(void) {

VERIFY_FIRMWARE_SUCCESS,

"Big FirmwareImage Verification");

firmware_blob = GetFirmwareBlob(image, &len);

- TEST_EQ(VerifyFirmware(root_key_blob, firmware_blob),

+ TEST_EQ(VerifyFirmware(root_key_blob, image->firmware_data, firmware_blob),

VERIFY_FIRMWARE_SUCCESS,

"Big Firmware Blob Verification");