Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1577001: Added GPU unit tests to win, mac and linux builds. They aren't running yet.... (Closed)

Created:
10 years, 8 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
alokp
CC:
chromium-reviews
Visibility:
Public.

Description

Added GPU unit tests to win, mac and linux builds. They aren't running yet. TEST=trybots BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43013

Patch Set 1 #

Total comments: 7

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -84 lines) Patch
M build/all.gyp View 1 2 5 chunks +5 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 1 2 6 chunks +66 lines, -82 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
apatrick_chromium
10 years, 8 months ago (2010-03-29 21:56:58 UTC) #1
alokp
lgtm http://codereview.chromium.org/1577001/diff/1/3 File build/all.gyp (right): http://codereview.chromium.org/1577001/diff/1/3#newcode96 build/all.gyp:96: '../gpu/demos/demos.gyp:*', could you also move gpu/demos/demos.gyp. http://codereview.chromium.org/1577001/diff/1/2 File ...
10 years, 8 months ago (2010-03-29 22:08:11 UTC) #2
apatrick_chromium
http://codereview.chromium.org/1577001/diff/1/3 File build/all.gyp (right): http://codereview.chromium.org/1577001/diff/1/3#newcode96 build/all.gyp:96: '../gpu/demos/demos.gyp:*', On 2010/03/29 22:08:11, alokp wrote: > could you ...
10 years, 8 months ago (2010-03-29 22:24:19 UTC) #3
alokp
http://codereview.chromium.org/1577001/diff/1/2 File gpu/gpu.gyp (right): http://codereview.chromium.org/1577001/diff/1/2#newcode317 gpu/gpu.gyp:317: 'command_buffer/common', really? I see a lot of _unittests targets ...
10 years, 8 months ago (2010-03-29 22:28:06 UTC) #4
apatrick_chromium
10 years, 8 months ago (2010-03-29 22:38:23 UTC) #5
Okay I'll change it.

Powered by Google App Engine
This is Rietveld 408576698