Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1576019: [Mac] Get theme providers from a window's delegate, not its window controller... (Closed)

Created:
10 years, 8 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Get theme providers from a window's delegate, not its window controller. These are actually the same object, but they are set at different times during the switch to fullscreen. BUG=39323 TEST=Go fullscreen with the Android Robot theme installed. Tab text for unselected tabs should be grey, not black. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/cocoa/chrome_browser_window.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/fullscreen_window.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rohitrao (ping after 24h)
So this change will fix the problem, but I'm very Meh about it. In the ...
10 years, 8 months ago (2010-04-05 23:07:56 UTC) #1
Avi (use Gerrit)
10 years, 8 months ago (2010-04-05 23:11:18 UTC) #2
LGTM

I'm totally OK with considering the delegate as the source of pixels rather than
the controller. Perhaps I'm a bit more pragmatic than you are, but if they're
the same thing, does it really matter? :)

Powered by Google App Engine
This is Rietveld 408576698