Issue 1575047: Port number string cache lookup for heap numbers in generatred code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1575047: Port number string cache lookup for heap numbers in generatred code. (Closed)

Created:
10 years, 8 months ago by podivilov

Modified:
9 years, 3 months ago

Reviewers:
Søren Thygesen Gjesse, sgjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port number string cache lookup for heap numbers in generatred code. Committed: http://code.google.com/p/v8/source/detail?r=4516

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -35 lines)			Patch
M	src/arm/codegen-arm.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 2	5 chunks	+56 lines, -19 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2	4 chunks	+51 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/1575047/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/1575047/diff/1/2#newcode7722 src/x64/codegen-x64.cc:7722: if (CpuFeatures::IsSupported(SSE2)) { No need to handle non ...

10 years, 8 months ago (2010-04-22 12:23:26 UTC) #2

podivilov

10 years, 8 months ago (2010-04-22 13:19:11 UTC) #3

All done, thanks!

http://codereview.chromium.org/1575047/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/1575047/diff/1/2#newcode7722
src/x64/codegen-x64.cc:7722: if (CpuFeatures::IsSupported(SSE2)) {
On 2010/04/22 12:23:26, Søren Gjesse wrote:
> No need to handle non SSE2 support as SSE2 is always supported on x64.

Done.

http://codereview.chromium.org/1575047/diff/1/3
File src/x64/codegen-x64.h (right):

http://codereview.chromium.org/1575047/diff/1/3#newcode942
src/x64/codegen-x64.h:942: static void
GenerateConvertHashCodeToIndex(MacroAssembler* masm,
On 2010/04/22 12:23:26, Søren Gjesse wrote:
> Indent.

Done.

Expand Messages | Collapse Messages

Issue 1575047: Port number string cache lookup for heap numbers in generatred code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages