GTK: Improve xfce detection.

GTK: Improve xfce detection.

On Hardy, the DESKTOP_SESSION environment variable is "xfce4" but on Karmic,
it is "xfce"

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44698

[Evan Martin, 2010-04-15 17:49:22]

LGTM

...gar, we don't have any tests for this code?  Even though we have the nice
envvargetter abstraction?  :~(

[Evan Stade, 2010-04-15 18:56:42]

http://codereview.chromium.org/1572042/diff/1/2
File base/linux_util.cc (right):

http://codereview.chromium.org/1572042/diff/1/2#newcode242
base/linux_util.cc:242: else if (desktop_session == "xfce4" || desktop_session
== "xfce")
desktop_session.find("xfce") ?

[Elliot Glaysher, 2010-04-15 19:27:43]

On 2010/04/15 17:49:22, Evan Martin wrote:
> ...gar, we don't have any tests for this code?  Even though we have the nice
> envvargetter abstraction?  :~(

Updated with unit tests.

[Evan Martin, 2010-04-15 19:30:59]

LGTM

I didn't mean to block your previous commit on this, but good on you.

http://codereview.chromium.org/1572042/diff/6001/7002
File base/linux_util.cc (right):

http://codereview.chromium.org/1572042/diff/6001/7002#newcode239
base/linux_util.cc:239: return DESKTOP_ENVIRONMENT_KDE4;
I wonder if this means we break on KDE5.  (Please don't let this comment deter
you from committing.)

http://codereview.chromium.org/1572042/diff/6001/7004
File base/linux_util_unittest.cc (right):

http://codereview.chromium.org/1572042/diff/6001/7004#newcode19
base/linux_util_unittest.cc:19: MOCK_METHOD2(GetEnv, bool(const char*,
std::string* result));
Whoa, you just blew my mind.