Parsing some kinds of integers and junk values in Runtime_NumberToString. For...

src/runtime.cc

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3339 matching lines @@
       {
         // Avoid accumulating new handles inside loop.
         HandleScope temp_scope;
         // Arguments array to replace function is match, captures, index and
         // subject, i.e., 3 + capture count in total.
         Handle<FixedArray> elements = Factory::NewFixedArray(3 + capture_count);
         elements->set(0, *Factory::NewSubString(subject,
                                                 match_start,
                                                 match_end));
         for (int i = 1; i <= capture_count; i++) {
           int start = register_vector[i * 2];

[Florian Loitsch, 2010/04/03 12:55:41]

unrelated patch?

[SeRya, 2010/04/05 07:54:36]

This change came with update (it is not shown as a difference in my working
copy).

           if (start >= 0) {
             int end = register_vector[i * 2 + 1];
             ASSERT(start <= end);
             Handle<String> substring = Factory::NewSubString(subject,
                                                              start,
                                                              end);
             elements->set(i, *substring);
           } else {
             ASSERT(register_vector[i * 2 + 1] < 0);
             elements->set(i, Heap::undefined_value());
@@ skipping 1104 matching lines @@
 
   // Fast case: short integer or some sorts of junk values.
   int len = subject->length();
   if (subject->IsSeqAsciiString()) {
     if (len == 0) return Smi::FromInt(0);
 
     char const* data = SeqAsciiString::cast(subject)->GetChars();
     bool minus = (data[0] == '-');
     int start_pos = (minus ? 1 : 0);
 
-    if (start_pos == len || data[start_pos] > '9') {
+    if (start_pos == len) {
+      return Heap::nan_value();
+    } else if (data[start_pos] > '9') {
       // Fast check for a junk value. A valid string may start from a
       // whitespace, a sign ('+' or '-'), the decimal point, a decimal digit or
       // the 'I' character ('Infinity'). All of that have codes not greater than
       // '9' except 'I'.
       if (data[start_pos] != 'I') {
         return Heap::nan_value();
       }
     } else if (len - start_pos < 10 && AreDigits(data, start_pos, len)) {
       // The maximal/minimal smi has 10 digits. If the string has less digits we
       // know it will fit into the smi-data type.
@@ skipping 5596 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     Counters::gc_last_resort_from_js.Increment();
     Heap::CollectAllGarbage(false);
   }
 }
 
 
 } }  // namespace v8::internal