Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 15703018: Improved Quickoffice editing about:flag. (Closed)

Created:
7 years, 6 months ago by dusk
Modified:
7 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Improved Quickoffice editing about:flag. We were sniffing extension name from an alternate manifest to drive experimental behaviour. This is apparant to the user and unnecessary. Now we use the alternate manifest to inject experimental feature capability into the background page that the extension can query and use. Change-Id: I6326d64b97723d0f102269cea02e5c9110e6fe1d BUG=237052 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206363

Patch Set 1 #

Patch Set 2 : Correcting manifest files for inbuilt extension. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -72 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/quick_office/manifest.json View 1 2 chunks +4 lines, -3 lines 2 comments Download
D chrome/browser/resources/quick_office/manifest_editor.json View 1 chunk +0 lines, -64 lines 0 comments Download
A + chrome/browser/resources/quick_office/manifest_experimental.json View 1 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dusk
Improved solution for QO experimental feature enabling.
7 years, 6 months ago (2013-06-11 19:27:34 UTC) #1
Dmitry Polukhin
https://codereview.chromium.org/15703018/diff/4001/chrome/browser/resources/quick_office/manifest.json File chrome/browser/resources/quick_office/manifest.json (right): https://codereview.chromium.org/15703018/diff/4001/chrome/browser/resources/quick_office/manifest.json#newcode4 chrome/browser/resources/quick_office/manifest.json:4: "scripts": [ Does this change require new js/html/nexe? If ...
7 years, 6 months ago (2013-06-12 04:25:31 UTC) #2
Dmitry Polukhin
LGTM As we discussed it offline this change should not break existing document viewer.
7 years, 6 months ago (2013-06-13 07:02:22 UTC) #3
James Hawkins
LGTM
7 years, 6 months ago (2013-06-13 23:24:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dskelton@chromium.org/15703018/4001
7 years, 6 months ago (2013-06-14 04:04:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=50053
7 years, 6 months ago (2013-06-14 05:04:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dskelton@chromium.org/15703018/4001
7 years, 6 months ago (2013-06-14 06:19:07 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 07:48:15 UTC) #8
Message was sent while issue was closed.
Change committed as 206363

Powered by Google App Engine
This is Rietveld 408576698