Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1569011: Make the browser survive massive data: URIs, via various techniques:... (Closed)

Created:
10 years, 8 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
jschuh, inferno
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Make the browser survive massive data: URIs, via various techniques: 1) Drop the URL limit from 10MB to 2MB. The browser survives without this, but that final tweaks makes the whole data: URI attack fairly smooth (on my admittedly powerful machine). 2) Elide the title string at kMaxTitleChars. We already have a hard title limit but there was a path whereby the title is implied by the URL (e.g. file: and data: etc). 3) For massive URLs, limit the length shown in URL bar. We need to support them, because someone might redirect to a data: URI with e.g. an image in it. However, attempting to show them would kill the browser. We can't elide them because eliding URLs is a security risk (and would lead to correctness issues with an edit/press enter cycle). So we show at least the origin (minus path) or just the scheme for data: URIs BUG=33952 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43319

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M chrome/browser/tab_contents/navigation_entry.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/toolbar_model.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Evans
Justin, can you look over this whilst the try bots ponder it? :)
10 years, 8 months ago (2010-03-31 23:17:42 UTC) #1
jschuh
LGTM
10 years, 8 months ago (2010-03-31 23:44:40 UTC) #2
inferno
10 years, 8 months ago (2010-04-01 00:35:24 UTC) #3
LGTM. thanks chris for preserving the url origin.

Powered by Google App Engine
This is Rietveld 408576698