Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1569009: Mark up debugger support in sample file (Closed)

Created:
10 years, 8 months ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Mark up debugger support in sample file Committed: http://code.google.com/p/v8/source/detail?r=4375

Patch Set 1 #

Total comments: 2

Patch Set 2 : follow codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M samples/lineprocessor.cc View 1 9 chunks +32 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Rybin
Hi Soren I am preparing my long-awaited document about adding a debugger support to V8-based ...
10 years, 8 months ago (2010-04-08 12:07:29 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/1569009/diff/1/2 File samples/lineprocessor.cc (right): http://codereview.chromium.org/1569009/diff/1/2#newcode29 samples/lineprocessor.cc:29: // Enable debugger support by default. Maybe explain ...
10 years, 8 months ago (2010-04-08 12:25:51 UTC) #2
Peter Rybin
10 years, 8 months ago (2010-04-09 13:01:12 UTC) #3
http://codereview.chromium.org/1569009/diff/1/2
File samples/lineprocessor.cc (right):

http://codereview.chromium.org/1569009/diff/1/2#newcode29
samples/lineprocessor.cc:29: // Enable debugger support by default.
On 2010/04/08 12:25:52, Søren Gjesse wrote:
> Maybe explain that this define is local to this file and what it is used for,
> and that if this is turned on the V8 library used need to be built with
debugger
> support (compiled with ENABLE_DEBUGGER_SUPPORT defined - which is a different
> one) for it to have any effect.

Done.

Powered by Google App Engine
This is Rietveld 408576698