Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: webkit/glue/plugins/webplugin_delegate_impl_mac.mm

Issue 1569005: Fix CoreGraphics and Core Animation drawing for QuickTime plugin (Closed)
Patch Set: Spacing fix Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/plugins/plugin_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/webplugin_delegate_impl_mac.mm
diff --git a/webkit/glue/plugins/webplugin_delegate_impl_mac.mm b/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
index d2445edd65bb9d86d4bf16557bc88b297b42bf25..a99c39e19059993c1aa5ed56125cd7171d1d94c3 100644
--- a/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
+++ b/webkit/glue/plugins/webplugin_delegate_impl_mac.mm
@@ -341,11 +341,16 @@ void WebPluginDelegateImpl::PlatformInitialize() {
UpdateIdleEventRate();
#endif
- // QuickTime can crash if it gets other calls (e.g., NPP_Write) before it
- // gets a SetWindow call, so call SetWindow (with a 0x0 rect) immediately.
- const WebPluginInfo& plugin_info = instance_->plugin_lib()->plugin_info();
- if (plugin_info.name.find(L"QuickTime") != std::wstring::npos)
- WindowlessSetWindow(true);
+ // QuickTime (in QD mode only) can crash if it gets other calls (e.g.,
+ // NPP_Write) before it gets a SetWindow call, so call SetWindow (with a 0x0
+ // rect) immediately.
+#ifndef NP_NO_QUICKDRAW
+ if (instance()->drawing_model() == NPDrawingModelQuickDraw) {
+ const WebPluginInfo& plugin_info = instance_->plugin_lib()->plugin_info();
+ if (plugin_info.name.find(L"QuickTime") != std::wstring::npos)
+ WindowlessSetWindow(true);
+ }
+#endif
}
void WebPluginDelegateImpl::PlatformDestroyInstance() {
« no previous file with comments | « webkit/glue/plugins/plugin_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698