Issue 1569005: Fix CoreGraphics and Core Animation drawing for QuickTime plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1569005: Fix CoreGraphics and Core Animation drawing for QuickTime plugin (Closed)

Created:
10 years, 8 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews

Visibility:
Public.

Description

Fix CoreGraphics and Core Animation drawing for QuickTime plugin Conditionalizes a SetWindow call that was added to fix a crash in QuickDraw mode, but isn't necessary (and causes QuickTime not to draw) in other drawing modes. BUG=38336, 36896, 35081 TEST=Play QuickTime movies on 10.6. The ones with floating controllers (36896) should draw again, and the other should not only work, but have smoother playback and use less CPU. The test case for bug 35081 should still not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43078

Patch Set 1 #

Patch Set 2 : Spacing fix #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -15 lines)			Patch
	M	webkit/glue/plugins/plugin_host.cc	View		1 chunk	+1 line, -10 lines	0 comments	Download
	M	webkit/glue/plugins/webplugin_delegate_impl_mac.mm	View	1	1 chunk	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM +100

Expand Messages | Collapse Messages