Issue 1568037: Enable Object.create tests since we implement this correctly (since 3786 i gu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1568037: Enable Object.create tests since we implement this correctly (since 3786 i gu... (Closed)

Created:
10 years, 8 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Enable Object.create tests since we implement this correctly (since 3786 i guess, it was enabled in 3438 but did not function correctly because DefineOwnProperty was not implemented fully according to spec). Committed: http://code.google.com/p/v8/source/detail?r=4522

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	test/es5conform/es5conform.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

After committing this we can close issue 460: http://code.google.com/p/v8/issues/detail?id=460

10 years, 8 months ago (2010-04-15 11:12:11 UTC) #1

Erik Corry

10 years, 8 months ago (2010-04-27 12:26:46 UTC) #2

LGTM
We must make sure that we correctly implement read-only integer named fields
before we claim this work is done.

Expand Messages | Collapse Messages