Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1568004: Remove run_webkit_tests dependency on third_party\python_24.... (Closed)

Created:
10 years, 9 months ago by Victor Wang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Remove run_webkit_tests dependency on third_party\python_24. R=dpranke,jeffbailey@google.com BUG=none TEST=build bot green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43224

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M webkit/tools/layout_tests/run_webkit_tests.bat View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/layout_tests/run_webkit_tests.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/run_webkit_tests.sh View 1 2 3 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Victor Wang
10 years, 9 months ago (2010-03-29 20:59:29 UTC) #1
M-A Ruel
http://codereview.chromium.org/1568004/diff/2001/3001 File webkit/tools/layout_tests/run_webkit_tests.bat (right): http://codereview.chromium.org/1568004/diff/2001/3001#newcode1 webkit/tools/layout_tests/run_webkit_tests.bat:1: python %~dp0\run_webkit_tests.py %* keep the @
10 years, 9 months ago (2010-03-29 21:05:02 UTC) #2
Victor Wang
Done On 2010/03/29 21:05:02, Marc-Antoine Ruel wrote: > http://codereview.chromium.org/1568004/diff/2001/3001 > File webkit/tools/layout_tests/run_webkit_tests.bat (right): > > ...
10 years, 9 months ago (2010-03-29 21:13:44 UTC) #3
Dirk Pranke
So, to be clear, after this change, we'll be assuming that Python is in the ...
10 years, 9 months ago (2010-03-29 21:17:00 UTC) #4
Victor Wang
Yes, I think that's the assumption. We already have python in depot_tools and my understanding ...
10 years, 9 months ago (2010-03-29 21:28:08 UTC) #5
Evan Martin
http://codereview.chromium.org/1568004/diff/7001/8003 File webkit/tools/layout_tests/run_webkit_tests.sh (right): http://codereview.chromium.org/1568004/diff/7001/8003#newcode13 webkit/tools/layout_tests/run_webkit_tests.sh:13: SCRIPT=$(cygpath -wa "$exec_dir/run_webkit_tests.py") Since you just fail inside of ...
10 years, 8 months ago (2010-03-30 16:57:26 UTC) #6
Victor Wang
10 years, 8 months ago (2010-03-30 17:25:58 UTC) #7
http://codereview.chromium.org/1568004/diff/7001/8003
File webkit/tools/layout_tests/run_webkit_tests.sh (right):

http://codereview.chromium.org/1568004/diff/7001/8003#newcode13
webkit/tools/layout_tests/run_webkit_tests.sh:13: SCRIPT=$(cygpath -wa
"$exec_dir/run_webkit_tests.py")
The script won't fail in py if user has user path set correctly
(depot_tools\python in user path, that's a windows version). But yes, the PATH
stuff should be removed so Python for windows can be used.

On 2010/03/30 16:57:26, Evan Martin wrote:
> Since you just fail inside of the .py anyway, I wonder if all of this PATH
> munging is necessary.

Powered by Google App Engine
This is Rietveld 408576698