Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1567022: Implement LoginDatabase on all platforms. (Closed)

Created:
10 years, 8 months ago by albertb
Modified:
9 years, 3 months ago
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Implement LoginDatabase on all platforms. BUG=35038 TEST=LoginDatabaseTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43667

Patch Set 1 #

Patch Set 2 : Remove references to LoginDatabaseMac #

Patch Set 3 : Fix mac headers #

Patch Set 4 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -70 lines) Patch
M chrome/browser/password_manager/login_database.h View 3 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/login_database.cc View 1 chunk +32 lines, -0 lines 0 comments Download
D chrome/browser/password_manager/login_database_mac.h View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/password_manager/login_database_mac.cc View 1 chunk +7 lines, -5 lines 0 comments Download
A chrome/browser/password_manager/login_database_posix.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/login_database_unittest.cc View 5 chunks +8 lines, -22 lines 0 comments Download
A chrome/browser/password_manager/login_database_win.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
albertb
Hi Stuart/Tim, Here's the first chunk of the giant login database patch. This just implements ...
10 years, 8 months ago (2010-04-05 22:08:04 UTC) #1
stuartmorgan
10 years, 8 months ago (2010-04-05 22:12:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698