chrome/browser/debugger/devtools_manager.cc - Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/devtools_manager.cc

Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window (Closed)

Patch Set: Asynchronous docking feedback. Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/debugger/devtools_manager.cc

diff --git a/chrome/browser/debugger/devtools_manager.cc b/chrome/browser/debugger/devtools_manager.cc

index bceec77feb0eb53f5541305932163422d4bc97cb..2b89d8f89ddcf8d8a26183ab8cc8c72387a19bb3 100644

--- a/chrome/browser/debugger/devtools_manager.cc

+++ b/chrome/browser/debugger/devtools_manager.cc

@@ -115,11 +115,11 @@ void DevToolsManager::CloseWindow(RenderViewHost* client_rvh) {

CloseWindow(client_host);

}

-void DevToolsManager::DockWindow(RenderViewHost* client_rvh) {

+void DevToolsManager::RequestDockWindow(RenderViewHost* client_rvh) {

ReopenWindow(client_rvh, true);

}

-void DevToolsManager::UndockWindow(RenderViewHost* client_rvh) {

+void DevToolsManager::RequestUndockWindow(RenderViewHost* client_rvh) {

ReopenWindow(client_rvh, false);

}