Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/renderer/devtools_client.h

Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window (Closed)
Patch Set: Asynchronous docking feedback. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/devtools_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_DEVTOOLS_CLIENT_H_ 5 #ifndef CHROME_RENDERER_DEVTOOLS_CLIENT_H_
6 #define CHROME_RENDERER_DEVTOOLS_CLIENT_H_ 6 #define CHROME_RENDERER_DEVTOOLS_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 28 matching lines...) Expand all
39 bool OnMessageReceived(const IPC::Message& message); 39 bool OnMessageReceived(const IPC::Message& message);
40 40
41 // WebDevToolsFrontendClient implementation 41 // WebDevToolsFrontendClient implementation
42 virtual void sendMessageToAgent( 42 virtual void sendMessageToAgent(
43 const WebKit::WebDevToolsMessageData& data); 43 const WebKit::WebDevToolsMessageData& data);
44 virtual void sendDebuggerCommandToAgent(const WebKit::WebString& command); 44 virtual void sendDebuggerCommandToAgent(const WebKit::WebString& command);
45 virtual void sendDebuggerPauseScript(); 45 virtual void sendDebuggerPauseScript();
46 46
47 virtual void activateWindow(); 47 virtual void activateWindow();
48 virtual void closeWindow(); 48 virtual void closeWindow();
49 virtual void dockWindow(); 49 virtual void requestDockWindow();
50 virtual void undockWindow(); 50 virtual void requestUndockWindow();
51 51
52 private: 52 private:
53 void OnRpcMessage(const DevToolsMessageData& data); 53 void OnRpcMessage(const DevToolsMessageData& data);
54 54
55 // Sends message to DevToolsAgent. 55 // Sends message to DevToolsAgent.
56 void Send(const IPC::Message& tools_agent_message); 56 void Send(const IPC::Message& tools_agent_message);
57 57
58 RenderView* render_view_; // host render view 58 RenderView* render_view_; // host render view
59 scoped_ptr<WebKit::WebDevToolsFrontend> web_tools_frontend_; 59 scoped_ptr<WebKit::WebDevToolsFrontend> web_tools_frontend_;
60 60
61 DISALLOW_COPY_AND_ASSIGN(DevToolsClient); 61 DISALLOW_COPY_AND_ASSIGN(DevToolsClient);
62 }; 62 };
63 63
64 #endif // CHROME_RENDERER_DEVTOOLS_CLIENT_H_ 64 #endif // CHROME_RENDERER_DEVTOOLS_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/devtools_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698