Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: chrome/browser/debugger/devtools_window.h

Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window (Closed)
Patch Set: Asynchronous docking feedback. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_manager.cc ('k') | chrome/browser/debugger/devtools_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 void SetDocked(bool docked); 45 void SetDocked(bool docked);
46 RenderViewHost* GetRenderViewHost(); 46 RenderViewHost* GetRenderViewHost();
47 47
48 TabContents* tab_contents() { return tab_contents_; } 48 TabContents* tab_contents() { return tab_contents_; }
49 Browser* browser() { return browser_; } // For tests. 49 Browser* browser() { return browser_; } // For tests.
50 bool is_docked() { return docked_; } 50 bool is_docked() { return docked_; }
51 51
52 private: 52 private:
53 void CreateDevToolsBrowser(); 53 void CreateDevToolsBrowser();
54 BrowserWindow* GetInspectedBrowserWindow(); 54 BrowserWindow* GetInspectedBrowserWindow();
55 void SetAttachedWindow();
55 56
56 // Overridden from NotificationObserver. 57 // Overridden from NotificationObserver.
57 virtual void Observe(NotificationType type, 58 virtual void Observe(NotificationType type,
58 const NotificationSource& source, 59 const NotificationSource& source,
59 const NotificationDetails& details); 60 const NotificationDetails& details);
60 61
61 void OpenConsole(); 62 void OpenConsole();
62 63
63 // Overridden from TabContentsDelegate. 64 // Overridden from TabContentsDelegate.
64 virtual void OpenURLFromTab(TabContents* source, 65 virtual void OpenURLFromTab(TabContents* source,
(...skipping 26 matching lines...) Expand all
91 TabContents* tab_contents_; 92 TabContents* tab_contents_;
92 Browser* browser_; 93 Browser* browser_;
93 bool docked_; 94 bool docked_;
94 bool is_loaded_; 95 bool is_loaded_;
95 bool open_console_on_load_; 96 bool open_console_on_load_;
96 NotificationRegistrar registrar_; 97 NotificationRegistrar registrar_;
97 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 98 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
98 }; 99 };
99 100
100 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 101 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/debugger/devtools_manager.cc ('k') | chrome/browser/debugger/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698