Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: chrome/browser/debugger/devtools_manager.h

Issue 1567014: Fix docking behaviour for devtools windows that don't have an associated browser window (Closed)
Patch Set: Asynchronous docking feedback. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 void ForwardToDevToolsAgent(RenderViewHost* client_rvh, 44 void ForwardToDevToolsAgent(RenderViewHost* client_rvh,
45 const IPC::Message& message); 45 const IPC::Message& message);
46 void ForwardToDevToolsAgent(DevToolsClientHost* from, 46 void ForwardToDevToolsAgent(DevToolsClientHost* from,
47 const IPC::Message& message); 47 const IPC::Message& message);
48 void ForwardToDevToolsClient(RenderViewHost* inspected_rvh, 48 void ForwardToDevToolsClient(RenderViewHost* inspected_rvh,
49 const IPC::Message& message); 49 const IPC::Message& message);
50 50
51 void ActivateWindow(RenderViewHost* client_rvn); 51 void ActivateWindow(RenderViewHost* client_rvn);
52 void CloseWindow(RenderViewHost* client_rvn); 52 void CloseWindow(RenderViewHost* client_rvn);
53 void DockWindow(RenderViewHost* client_rvn); 53 void RequestDockWindow(RenderViewHost* client_rvn);
54 void UndockWindow(RenderViewHost* client_rvn); 54 void RequestUndockWindow(RenderViewHost* client_rvn);
55 55
56 void OpenDevToolsWindow(RenderViewHost* inspected_rvh); 56 void OpenDevToolsWindow(RenderViewHost* inspected_rvh);
57 void ToggleDevToolsWindow(RenderViewHost* inspected_rvh, bool open_console); 57 void ToggleDevToolsWindow(RenderViewHost* inspected_rvh, bool open_console);
58 void RuntimeFeatureStateChanged(RenderViewHost* inspected_rvh, 58 void RuntimeFeatureStateChanged(RenderViewHost* inspected_rvh,
59 const std::string& feature, 59 const std::string& feature,
60 bool enabled); 60 bool enabled);
61 61
62 // Starts element inspection in the devtools client. 62 // Starts element inspection in the devtools client.
63 // Creates one by means of OpenDevToolsWindow if no client 63 // Creates one by means of OpenDevToolsWindow if no client
64 // exists. 64 // exists.
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 141
142 typedef std::map<int, std::pair<DevToolsClientHost*, RuntimeFeatures> > 142 typedef std::map<int, std::pair<DevToolsClientHost*, RuntimeFeatures> >
143 OrphanClientHosts; 143 OrphanClientHosts;
144 OrphanClientHosts orphan_client_hosts_; 144 OrphanClientHosts orphan_client_hosts_;
145 int last_orphan_cookie_; 145 int last_orphan_cookie_;
146 146
147 DISALLOW_COPY_AND_ASSIGN(DevToolsManager); 147 DISALLOW_COPY_AND_ASSIGN(DevToolsManager);
148 }; 148 };
149 149
150 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 150 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698