Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1567007: Move the AstVisitor stack check from Accept to Visit. (Closed)

Created:
10 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Move the AstVisitor stack check from Accept to Visit. The stack check has been moved from the Accept function dispatching on the AST node type, earlier to the Visit function dispatching on the visitor type. This allows very simple non-recursive visitors (not taking extra arguments or returning values) via the convention of calling "Visit" if one wants the stack check and "Accept" if one does not. Recursive calls should all be via "Visit". Committed: http://code.google.com/p/v8/source/detail?r=4320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M src/ast.h View 1 chunk +4 lines, -10 lines 0 comments Download
M src/ast.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M src/flow-graph.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 8 months ago (2010-03-30 12:12:01 UTC) #1
fschneider
10 years, 8 months ago (2010-03-30 12:25:02 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698