Issue 1566013: Fixes a problem with filename lookups when not using encoding....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1566013: Fixes a problem with filename lookups when not using encoding.... (Closed)

Created:
10 years, 8 months ago by grmocg

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, mbelshe

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fixes a problem with filename lookups when not using encoding. Small cleanups to make compilation easier elsewhere.

Patch Set 1 #

Total comments: 3

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	net/tools/flip_server/balsa_headers.cc	View		2 chunks	+2 lines, -2 lines	2 comments	Download
	M	net/tools/flip_server/flip_in_mem_edsm_server.cc	View		2 chunks	+9 lines, -3 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

10 years, 8 months ago (2010-04-02 19:41:28 UTC) #1

sorry for nits - 

otherwise lgtm

http://codereview.chromium.org/1566013/diff/1/3
File net/tools/flip_server/balsa_headers.cc (right):

http://codereview.chromium.org/1566013/diff/1/3#newcode613
net/tools/flip_server/balsa_headers.cc:613: int len_converted = snprintf(buffer,
sizeof(buffer), "%ld", (long int)length);
nit: static_cast<long int>(length)

http://codereview.chromium.org/1566013/diff/1/3#newcode722
net/tools/flip_server/balsa_headers.cc:722: "%ld", (long
int)parsed_response_code);
nit: static_cast.

http://codereview.chromium.org/1566013/diff/1/2
File net/tools/flip_server/flip_in_mem_edsm_server.cc (right):

http://codereview.chromium.org/1566013/diff/1/2#newcode6
net/tools/flip_server/flip_in_mem_edsm_server.cc:6: #include <netinet/tcp.h>  //
For TCP_NODELAY on some distros, this needs to be <linux/tcp.h>
nit: 80 columns.

Expand Messages | Collapse Messages