Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1566005: Fix except clauses with multiple browser names. The scripts parse the list on... (Closed)

Created:
10 years, 8 months ago by kkania
Modified:
9 years, 7 months ago
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Fix except clauses with multiple browser names. The scripts parse the list on spaces, so delete the extra whitespace. Also, special case Chrome for one v8 test, in which Chrome expects no parenthesis around the exception. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M tests/selenium/javascript_unit_test_list.txt View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/selenium/sample_list.txt View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/selenium/tests/v8-test.html View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kkania
The test fixes I made a couple weeks ago didn't all take effect because the ...
10 years, 8 months ago (2010-03-30 17:29:22 UTC) #1
vangelis
10 years, 8 months ago (2010-03-30 17:54:11 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698