Issue 1566001: Update icudt42.dll ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1566001: Update icudt42.dll ... (Closed)

Created:
10 years, 9 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
jschuh

CC:
chromium-reviews, pam+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update icudt42.dll 1. Trim down Oriya data (see http://codereview.chromium.org/1429002 ). 2. Build icudt42.dll with NXCOMPAT and DYNAMICBASE. It shouldn't make any difference in terms of security because icudt42.dll is a pure data dll. This is mainly to make our checking tool happy. 3. Make a couple of changes in the source file to get rid of warnings from Visual C++/gcc. It turned out that the upstream already has this patch. (remove_warnings.patch) 4. Change icu.vsprops to ignore '4996' warnings (deprecated function warning) because ICU itself uses its deprecated functions. This will be followed by DEPS change to roll this in. BUG=38001, 39303 TEST=NONE TBR=jschuh Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42961

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -7 lines)			Patch
M	third_party/icu/README.chromium	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/icu/build/icu.vsprops	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	third_party/icu/icudt42.dll	View	Binary file		0 comments	Download
A	third_party/icu/patches/remove_warnings.patch	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	third_party/icu/source/i18n/colldata.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/icu/source/tools/toolutil/swapimpl.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages