Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py

Issue 1565001: test: Clean up site_login.py a bit. (Closed)
Patch Set: update one more call to attempt_logout() Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
diff --git a/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py b/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
index 7a4e2c8acb76c1102123a8556945cba46ad5d927..3fab4f3ef974fd885fa966b27044ef66130b4652 100644
--- a/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
+++ b/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
@@ -3,7 +3,7 @@
# found in the LICENSE file.
import logging, os, time
-from autotest_lib.client.bin import site_login, test
+from autotest_lib.client.bin import site_ui_test, test
from autotest_lib.client.common_lib import error, site_ui, utils
def wait_for_ibus_daemon_or_die(timeout=10):
@@ -18,12 +18,11 @@ def wait_for_ibus_daemon_or_die(timeout=10):
raise error.TestFail('ibus-daemon is not running')
-class desktopui_IBusTest(test.test):
+class desktopui_IBusTest(site_ui_test.UITest):
version = 1
preserve_srcdir = True
def setup(self):
- self.job.setup_dep(['autox'])
self.job.setup_dep(['ibusclient'])
@@ -70,23 +69,14 @@ class desktopui_IBusTest(test.test):
def run_once(self):
- logged_in = site_login.logged_in()
- if not logged_in:
- if not site_login.attempt_login(self, 'autox_script.json'):
- raise error.TestFail('Could not login')
- try:
- wait_for_ibus_daemon_or_die()
- dep = 'ibusclient'
- dep_dir = os.path.join(self.autodir, 'deps', dep)
- self.job.install_pkg(dep, 'dep', dep_dir)
-
- self.exefile = os.path.join(self.autodir,
- 'deps/ibusclient/ibusclient')
- self.test_reachable()
- self.test_supported_engines()
- for type_name in ['boolean', 'int', 'double', 'string']:
- self.test_config(type_name)
- finally:
- # If we started logged out, log back out.
- if not logged_in:
- site_login.attempt_logout()
+ wait_for_ibus_daemon_or_die()
+ dep = 'ibusclient'
+ dep_dir = os.path.join(self.autodir, 'deps', dep)
+ self.job.install_pkg(dep, 'dep', dep_dir)
+
+ self.exefile = os.path.join(self.autodir,
+ 'deps/ibusclient/ibusclient')
+ self.test_reachable()
+ self.test_supported_engines()
+ for type_name in ['boolean', 'int', 'double', 'string']:
+ self.test_config(type_name)

Powered by Google App Engine
This is Rietveld 408576698