Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: client/bin/site_ui_test.py

Issue 1565001: test: Clean up site_login.py a bit. (Closed)
Patch Set: update one more call to attempt_logout() Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/bin/site_login.py ('k') | client/bin/site_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/bin/site_ui_test.py
diff --git a/client/bin/site_ui_test.py b/client/bin/site_ui_test.py
index cbef8bce2123debd4a246fddf5f2f796f3f05bc2..e86087763acf3c6b49eeecba2f30391c144b7a3f 100644
--- a/client/bin/site_ui_test.py
+++ b/client/bin/site_ui_test.py
@@ -23,19 +23,12 @@ class UITest(bin_test.test):
def initialize(self, script='autox_script.json'):
# Clean up past state and assume logged out before logging in.
if site_login.logged_in():
- if not site_login.attempt_logout(timeout=10):
- raise error.TestFail('Could not logout from previous session')
- if not site_login.wait_for_browser():
- raise error.TestFail("Login manager did not restart")
+ site_login.attempt_logout()
# Test account information embedded into json file.
- if not site_login.attempt_login(self, script):
- raise error.TestFail('Login failed at the beginning of new session')
+ site_login.attempt_login(self, script)
+ site_login.wait_for_initial_chrome_window()
-
- """
- Logs out when object is deleted
- """
def cleanup(self):
- if not site_login.attempt_logout():
- raise error.TestFail('Could not logout at end of session')
+ """Logs out when object is deleted"""
+ site_login.attempt_logout()
« no previous file with comments | « client/bin/site_login.py ('k') | client/bin/site_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698