Issue 1564010: sync: Specify linking dependencies correctly. The browser library contains lo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1564010: sync: Specify linking dependencies correctly. The browser library contains lo... (Closed)

Created:
10 years, 8 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow), Zachary Kuznia, tim (not reviewing), akalin

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

sync: Specify linking dependencies correctly. The browser library contains lots of files in chrome/browser/sync. They need to depend on the syncapi library and not just sync_proto. BUG=none TEST=Random CLs don't trigger linking errors. TBR=nick Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43675

Patch Set 1 #

Patch Set 2 : get it right this time #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	chrome/chrome_browser.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/chrome_tests.gypi	View	1	6 chunks	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

On 2010/04/05 18:20:30, Lei Zhang wrote: > +more sync folks > > ping Sync team ...

10 years, 8 months ago (2010-04-05 23:18:21 UTC) #3

ncarter (slow)

10 years, 8 months ago (2010-04-05 23:30:17 UTC) #4

On 2010/04/05 23:18:21, Lei Zhang wrote:
> On 2010/04/05 18:20:30, Lei Zhang wrote:
> > +more sync folks
> > 
> > ping
> 
> Sync team 404? I'm land this. TBR=nick

LGTM

Expand Messages | Collapse Messages