Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1562023: Fixes crash in autocomplete when typing some URLs. The problem... (Closed)

Created:
10 years, 8 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Fixes crash in autocomplete when typing some URLs. The problem occurred because HistoryURLProvider used the url to determine what to markup vs the actual text. BUG=41054 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44282

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
10 years, 8 months ago (2010-04-12 20:29:51 UTC) #1
Peter Kasting
LGTM, but maybe you should add comments about why we go this route instead of ...
10 years, 8 months ago (2010-04-12 20:59:45 UTC) #2
sky
10 years, 8 months ago (2010-04-12 22:10:24 UTC) #3
OK

Powered by Google App Engine
This is Rietveld 408576698