Issue 1560029: Fix File() to work with SVN 1.4 by using svn export in place...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1560029: Fix File() to work with SVN 1.4 by using svn export in place... (Closed)

Created:
10 years, 8 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fix File() to work with SVN 1.4 by using svn export in place of svn co --depth. This should work even if you change svn versions between gclient syncs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44441

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -16 lines)			Patch
M	gclient_scm.py	View	1 2	1 chunk	+24 lines, -9 lines	0 comments	Download
M	scm.py	View	1 2	2 chunks	+20 lines, -0 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	1 2 3	3 chunks	+85 lines, -3 lines	0 comments	Download
M	tests/scm_unittest.py	View	2	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Can you make SVN.AssertVersion cache the current installed version? lgtm with that.

10 years, 8 months ago (2010-04-13 19:43:54 UTC) #2

tony

10 years, 8 months ago (2010-04-14 02:35:54 UTC) #3

On 2010/04/13 19:43:54, Marc-Antoine Ruel wrote:
> Can you make SVN.AssertVersion cache the current installed version?

Done.

> lgtm with that.

Thanks!

Expand Messages | Collapse Messages