Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1560015: Replace omnibox icons with new set that are all the same size (19x19).... (Closed)

Created:
10 years, 8 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org, Evan Stade
Visibility:
Public.

Description

Replace omnibox icons with new set that are all the same size (19x19). TBR=jnj BUG=27570 TEST=Type "paypal.com", watch as it loads, ensure address doesn't shift sideways when the lock appears. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -42 lines) Patch
D chrome/app/theme/ev_secure.png View Binary file 0 comments Download
D chrome/app/theme/o2_globe.png View Binary file 0 comments Download
D chrome/app/theme/o2_globe_selected.png View Binary file 0 comments Download
D chrome/app/theme/o2_globe_selected_dark.png View Binary file 0 comments Download
D chrome/app/theme/o2_history.png View Binary file 0 comments Download
D chrome/app/theme/o2_history_selected.png View Binary file 0 comments Download
D chrome/app/theme/o2_history_selected_dark.png View Binary file 0 comments Download
D chrome/app/theme/o2_more.png View Binary file 0 comments Download
D chrome/app/theme/o2_more_selected.png View Binary file 0 comments Download
D chrome/app/theme/o2_more_selected_dark.png View Binary file 0 comments Download
D chrome/app/theme/o2_search.png View Binary file 0 comments Download
D chrome/app/theme/o2_search_selected.png View Binary file 0 comments Download
D chrome/app/theme/o2_search_selected_dark.png View Binary file 0 comments Download
D chrome/app/theme/o2_star.png View Binary file 0 comments Download
D chrome/app/theme/o2_star_selected.png View Binary file 0 comments Download
D chrome/app/theme/o2_star_selected_dark.png View Binary file 0 comments Download
A + chrome/app/theme/omnibox_history.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_history_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_history_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_http.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_http_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_http_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_https_green.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_https_invalid.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_https_valid.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_https_warning.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_more.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_more_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_more_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_search.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_search_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_search_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_star.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_star_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_star_lit.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/theme/omnibox_star_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/secure.png View Binary file 0 comments Download
D chrome/app/theme/security_error.png View Binary file 0 comments Download
D chrome/app/theme/security_warning.png View Binary file 0 comments Download
D chrome/app/theme/star.png View Binary file 0 comments Download
D chrome/app/theme/star_Template.pdf View Binary file 0 comments Download
D chrome/app/theme/starred.pdf View Binary file 0 comments Download
D chrome/app/theme/starred.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 3 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_unittest.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/theme_resources_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/toolbar_model.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
There's really nothing to review here, so TBRing. The trybots can't test anyway since this ...
10 years, 8 months ago (2010-04-05 23:36:08 UTC) #1
sky
LGTM
10 years, 8 months ago (2010-04-05 23:51:34 UTC) #2
Scott Hess - ex-Googler
10 years, 8 months ago (2010-04-05 23:54:47 UTC) #3 
LGTM, hope the bots agree.

Powered by Google App Engine
This is Rietveld 408576698