Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 155981: This file is not building on Windows, and I have no time to investigate,... (Closed)

Created:
11 years, 5 months ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
agl, jamesr1
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This file is not building on Windows, and I have no time to investigate, but we have to turn the tree green. Can you please take a look? Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ipc/ipc.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Sylvain
11 years, 5 months ago (2009-07-23 02:59:32 UTC) #1
jamesr1
11 years, 5 months ago (2009-07-23 03:32:07 UTC) #2
My bad, this file should only be build on posix.  It's to test
file_descriptor_posix.(h|cc), which does only build on posix due to the
target_default regexes.  chrome.gyp (where this test used to be defined) had an
exclusion rule for this file that I missed when moving over to ipc/.

The proper fix is to add an incantation like this to the ipc_tests target of
ipc.gyp:

['OS=="win"', {
          'sources!': [
            'file_descriptor_set_unittest.cc',
          ],
]

I'll test this in the morning.

Powered by Google App Engine
This is Rietveld 408576698