Issue 155959: re-do CL 21252 - move image_diff to tools, add deps to test_shell...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155959: re-do CL 21252 - move image_diff to tools, add deps to test_shell... (Closed)

Created:
11 years, 5 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

re-do CL 21252 - move image_diff to tools, add deps to test_shell CL 21252 seems to have had some svn brokenness (not sure why). I've recreated it and resubmitted it. The changes are to move image_diff from chrome/tools/test to tools/, and to make test_shell depend on image_diff and npapi_layout_test_plugin (and test_worker, where applicable) R=nsylvain@chromium.org TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21366

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -377 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/tools/test/image_diff/image_diff.cc	View	1 chunk	+0 lines, -364 lines	0 comments	Download
A	tools/image_diff/image_diff.gyp	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A +	tools\image_diff\image_diff.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, good luck

Expand Messages | Collapse Messages