Issue 155951: Disk cache: Fix handling of invalid entries that are detected...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155951: Disk cache: Fix handling of invalid entries that are detected... (Closed)

Created:
11 years, 5 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, willchan no longer on Chromium, Nirnimesh, Erik does not do reviews, dank, the_wrong_timurrrr, stuartmorgan, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Fix handling of invalid entries that are detected when doing evictions or enumerations. This cl fixes an issue with dirty entries being deleted twice from disk, and improves the whole thing so that different flavors or corrupt entries are removed gracefully. We started deleting things twice when we created the map of currently-open entries, because we don't want to have dirty entries on that map, so it is possible to have multiple EntryImpl objects that refer to the same entry (for corrupt entries). BUG=17474 TEST=Unittests, stress_cache.exe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21360

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -80 lines)			Patch
M	net/data/purify/net_unittests.exe.gtest.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/data/valgrind/net_unittests.gtest.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/backend_impl.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	net/disk_cache/backend_impl.cc	View	7 chunks	+58 lines, -28 lines	0 comments	Download
M	net/disk_cache/backend_unittest.cc	View	4 chunks	+72 lines, -10 lines	0 comments	Download
M	net/disk_cache/eviction.cc	View	5 chunks	+16 lines, -10 lines	0 comments	Download
M	net/disk_cache/rankings.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	net/disk_cache/rankings.cc	View	6 chunks	+20 lines, -22 lines	0 comments	Download
M	net/disk_cache/storage_block.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	net/disk_cache/storage_block-inl.h	View	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages