Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 155917: Fix two deallocation bugs identified by Coverity Prevent.... (Closed)

Created:
11 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix two deallocation bugs identified by Coverity Prevent. 1. The tables array allocated in the CompilationSubCache constructor was never deallocated. Fixed by adding destructor. 2. The buffer allocated in one of the constructors of the NoAllocationStringAllocator was never deallocated. It seems that this class sometimes owns the buffer (if it allocated one itself) and sometimes doesn't (if it was passed one). Simple fix is to remove the offending constructor which was never used anyway. Committed: http://code.google.com/p/v8/source/detail?r=2520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/compilation-cache.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/string-stream.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/string-stream.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 5 months ago (2009-07-22 09:51:20 UTC) #1
Christian Plesner Hansen
11 years, 5 months ago (2009-07-22 10:14:36 UTC) #2
Lgtm

Powered by Google App Engine
This is Rietveld 408576698