Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 155916: Introduce a external allocation limit.... (Closed)

Created:
11 years, 5 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Introduce a external allocation limit. If V8 is holding on to a lot of external memory, we attempt to clean it up even if we do not get an allocation failure. Since tiny V8 objects can hold on to a lot of external memory, we might run out of external memory while waiting for a normal allocation failure. Committed: http://code.google.com/p/v8/source/detail?r=2519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M src/heap.h View 4 chunks +7 lines, -18 lines 0 comments Download
M src/heap.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap-inl.h View 1 chunk +25 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 5 months ago (2009-07-22 09:22:29 UTC) #1
Kevin Millikin (Chromium)
11 years, 5 months ago (2009-07-22 09:55:45 UTC) #2
LGTM.  Could make it 8*semispace_size_ if you like that sort of thing (powers of
two).

Powered by Google App Engine
This is Rietveld 408576698