Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1559033: Reapply load ICs for nonexistent properties.... (Closed)

Created:
10 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Reapply load ICs for nonexistent properties. We need to be careful to check global property cells for the property encountered during lookup. Therefore, the ICs have to be specific to the name of the property if global objects are involved. In principle, this means that we could get a large number of monomorphic ICs for the same map if there is a global object in the prototype chain. However, since this is only done for normal load ICs and not for keyed load ICs I do not expect this to be a problem. I will experiment with it once this goes in. BUG=675 Committed: http://code.google.com/p/v8/source/detail?r=4426

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -38 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 3 chunks +71 lines, -13 lines 1 comment Download
M src/globals.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 chunks +67 lines, -11 lines 0 comments Download
M src/ic.cc View 2 chunks +5 lines, -2 lines 1 comment Download
M src/stub-cache.h View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M src/stub-cache.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 chunks +71 lines, -11 lines 0 comments Download
A test/mjsunit/regress/regress-675.js View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (chromium)
10 years, 8 months ago (2010-04-15 09:18:31 UTC) #1
Erik Corry
This LGTM but it would be nice to still share the load IC for all ...
10 years, 8 months ago (2010-04-15 09:38:09 UTC) #2
Mads Ager (chromium)
On 2010/04/15 09:38:09, Erik Corry wrote: > This LGTM but it would be nice to ...
10 years, 8 months ago (2010-04-15 10:05:42 UTC) #3
Erik Corry
10 years, 8 months ago (2010-04-15 10:28:44 UTC) #4
STV!

http://codereview.chromium.org/1559033/diff/2002/17008
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/1559033/diff/2002/17008#newcode1437
src/arm/stub-cache-arm.cc:1437: // Return undefined if maps of the full
prototype chain is still the
maps ... is -> maps ... are

http://codereview.chromium.org/1559033/diff/2002/17005
File src/ic.cc (right):

http://codereview.chromium.org/1559033/diff/2002/17005#newcode697
src/ic.cc:697: // Bail out if the result is not cachable.
http://www.googlefight.com/index.php?lang=en_GB&word1=cacheable&word2=cachable

Powered by Google App Engine
This is Rietveld 408576698