Issue 1559022: Pass tools/licenses.py for a few more directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1559022: Pass tools/licenses.py for a few more directories. (Closed)

Created:
10 years, 8 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Visibility:
Public.

Description

Pass tools/licenses.py for a few more directories. Getting very close to done. BUG=39240 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44099

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -28 lines)			Patch
M	third_party/scons/README.chromium	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	third_party/swig/README.chromium	View	1 chunk	+16 lines, -17 lines	0 comments	Download
A	third_party/tlslite/LICENSE	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/tlslite/README.chromium	View	1 chunk	+2 lines, -3 lines	1 comment	Download
M	third_party/yasm/README.chromium	View	1 chunk	+4 lines, -0 lines	1 comment	Download
A	third_party/zlib/LICENSE	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	third_party/zlib/README.chromium	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

10 years, 8 months ago (2010-04-09 01:58:32 UTC) #2

lgtm

http://codereview.chromium.org/1559022/diff/1/5
File third_party/tlslite/README.chromium (right):

http://codereview.chromium.org/1559022/diff/1/5#newcode9
third_party/tlslite/README.chromium:9: The change is in google.patch.
I'd like to have the patch renamed to chromium.patch while at it.

http://codereview.chromium.org/1559022/diff/1/6
File third_party/yasm/README.chromium (right):

http://codereview.chromium.org/1559022/diff/1/6#newcode123
third_party/yasm/README.chromium:123: 10) If all that's is finished, attempt to
build....and cross your fingers.
I love READMEs that finish with "cross your fingers".

Expand Messages | Collapse Messages