Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: chrome/browser/gtk/bookmark_bar_gtk.cc

Issue 155902: Don't create new tabs for middle clicks on bookmark items when the user relea... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: clarification Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_bar_gtk.cc
===================================================================
--- chrome/browser/gtk/bookmark_bar_gtk.cc (revision 21217)
+++ chrome/browser/gtk/bookmark_bar_gtk.cc (working copy)
@@ -558,6 +558,12 @@
return FALSE;
}
+ // Don't take any action if the user releases outside the button.
+ if (event->x < 0 || event->y < 0 || event->x >= sender->allocation.width ||
+ event->y >= sender->allocation.height) {
+ return FALSE;
+ }
+
const BookmarkNode* node = bar->GetNodeForToolButton(sender);
DCHECK(node);
DCHECK(bar->page_navigator_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698