Issue 1559004: Fix the case of no words to copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1559004: Fix the case of no words to copy. (Closed)

Created:
10 years, 8 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Visibility:
Public.

Description

Fix the case of no words to copy. CopyWords cannot actually copy zero words---it'd clobber destiantion with the first word of source. Add an ASSERT to check this condition plus update array builtins to verify for amount of copied data when necessary. TBR=vitalyr@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=4313

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
	M	src/builtins.cc	View		5 chunks	+22 lines, -10 lines	0 comments	Download
	M	src/utils.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages